Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/postgresql] Fixed service name to be able to override it#1910

Closed
rodcloutier wants to merge 1 commit intohelm:masterfrom
rodcloutier:postgres_configurable_service_name_support
Closed

[stable/postgresql] Fixed service name to be able to override it#1910
rodcloutier wants to merge 1 commit intohelm:masterfrom
rodcloutier:postgres_configurable_service_name_support

Conversation

@rodcloutier
Copy link

@rodcloutier rodcloutier commented Sep 1, 2017

Changed the name of the service to not use the name of the release.

This currently prevents the chart from being used as requirements since addressing the service from another chart requires to know the name of the future release.

Given an umbrella chart that would provide both postgresql and another chart that would use postgresql:

# requirement.yaml
dependencies:
- name: postgresql
  version: 0.8.1
  repository: @stable
- name: my-chart
  version: 0.1.0
  repository: @local

If my-chart has the following required values (to find the postgresql service):

# values.yaml

# This currently cannot be achieved since we would need to know ahead
# of time the name of the release
my-chart:
  pgdb_service: <name of the service>

The proposed changed would allow:

# values.yaml
postgresql:
  nameOverride: my-postgresql
my-chart:
  pgdb_service: my-postgresql

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 1, 2017

Hi @rodcloutier. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2017
@mgoodness mgoodness self-assigned this Sep 4, 2017
@mgoodness
Copy link
Contributor

mgoodness commented Sep 10, 2017

After #1777 you can refer to the postgres service using {{ template "postgresql.fullname" . }}.

Closing this PR, but feel free to reopen if the above doesn't work for you.

@mgoodness mgoodness closed this Sep 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mgoodness mgoodness

Labels

awaiting review cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rodcloutier @k8s-ci-robot @mgoodness